Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gsl include directory at compilation #1039

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add gsl include directory at compilation #1039

merged 1 commit into from
Dec 18, 2024

Conversation

mtaillefumier
Copy link
Collaborator

cmake searches for GSL but the target is used nowhere leading to a compilation error. GSL::gsl should be added to sirius_cxx to fix the potential issue

cmake searches for GSL but the target is used nowhere leading to a compilation error. GSL::gsl should be added to sirius_cxx to fix the potential issue
Copy link
Collaborator

@simonpintarelli simonpintarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I wonder why it was linking gsl correctly in spack?

I double checked that it doesn't link gsl cblas. In the current cmake this is a separate target, iirc this wasn't always the case.

@mtaillefumier mtaillefumier merged commit b5145ef into develop Dec 18, 2024
4 checks passed
@mtaillefumier mtaillefumier deleted the gsl_fix branch December 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants