-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] better organise namespace #896
Conversation
cscs-ci run default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can just put ETH Zurich / CSCS instead of the authors because we can always trace the authors back with github and commits.
The git blame is not necessarily the same as the author, due to reformatting or other cosmetic changes. But is a global license file not enough? It would probably safe a few kb to remove the boiler plate header :) |
|
|
we do not have to do it now, I wanted to put the question on the table because we will eventually have to do something like this. I guess we can just leave it as is until SIRIUS really see external developers contribute to it. |
Licencing each file is also fine. |
This PR touches a lot of files, but it doesn't change the logic of the code. Only source file reshuffling and namespace organisation. Unused cuda code is removed. What is left is la:: space, but this will be done in separate PR after #900