support email invite #3739
Merged
support email invite #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Jul 27, 2021
...oid/src/main/java/org/matrix/android/sdk/internal/session/identity/Sign3pidInvitationTask.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/matrix/android/sdk/internal/session/identity/model/SignInvitationResult.kt
Show resolved
Hide resolved
| @@ -253,7 +253,7 @@ internal interface RoomAPI { | |||
| @POST(NetworkConstants.URI_API_PREFIX_PATH_R0 + "join/{roomIdOrAlias}") | |||
| suspend fun join(@Path("roomIdOrAlias") roomIdOrAlias: String, | |||
| @Query("server_name") viaServers: List<String>, | |||
| @Body params: Map<String, String?>): JoinRoomResponse | |||
| @Body params: @JvmSuppressWildcards Map<String, Any>): JoinRoomResponse | |||
...x-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/PermalinkParser.kt
Outdated
Show resolved
Hide resolved
BillCarsonFr
force-pushed
the
feature/bca/accept_unbound_3pid_invite
branch
from
62458f0
to
af8dd26
Compare
BillCarsonFr
added
the
Z-NextRelease
BillCarsonFr
force-pushed
the
feature/bca/accept_unbound_3pid_invite
branch
from
af8dd26
to
6c2a052
Compare
bmarty
reviewed
Aug 27, 2021
...ix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/identity/IdentityAPI.kt
Show resolved
Hide resolved
bmarty
reviewed
Aug 27, 2021
...oid/src/main/java/org/matrix/android/sdk/internal/session/identity/Sign3pidInvitationTask.kt
Outdated
Show resolved
Hide resolved
BillCarsonFr
force-pushed
the
feature/bca/accept_unbound_3pid_invite
branch
from
f73eb91
to
efa9ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3695
Fixes #3691
Supports accepting email invite when the email is not bound to the account.
When your email is bound to an identity server and you are invited by email to a room, the invite will come down as part of the sync and the invite will appear in the UI. If not (no identity server or no mail bound), the invite will not show in the UX.
This PR will allow to accept invites on Element Android when your email is not bound to an IS by using Ephemeral Invitation Signing
When clicking on the link of the email invite, EA will open and will allow you to validate the invitation.
NB: The link generated in the API is a v1 link that is deprecated, so EA will use v1 API. v2 API cannot be used now because it requires auth and accept terms, and it degrades the invite flow too much.
Ideally EA should perform the signing locally as it as all info and is crypto capabale, but the documentation is not saying what the signing should be :/
Web would display:
The email invite looks like that
In prevision of MSC3288 this PR also support a room_type event in the link in order to adapt the invite text.