Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use portal for background and autostart #2085

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Use portal for background and autostart #2085

merged 6 commits into from
Oct 20, 2023

Conversation

lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team September 17, 2023 10:21
leolost2605
leolost2605 previously approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@danirabbit
Copy link
Member

My only concern about this is, if someone never opens appcenter does that mean they’ll never get update notifications?

danirabbit
danirabbit approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're at the beginning of a new cycle, this is the time for experimentation! So let's try it and see if updates become a concern during testing

@danirabbit danirabbit enabled auto-merge (squash) October 20, 2023 16:31
@danirabbit danirabbit merged commit 149c8e2 into master Oct 20, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/use-background-portal branch October 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

@leolost2605 leolost2605 leolost2605 left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenemter @danirabbit @leolost2605