Filter screenshot by environment (elementary#2210) #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2024 08:31
Will read the environment property of the screenshot and will only show them if prefer dark mode is enabled in the system and the screenshot has a dark mode environment (i.e. has ':dark' in the environment id). Won't consider null environments in the screenshots.
danirabbit
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short summary
Aims to implement #2210
Will read the environment property of the screenshot and will filter it out if:
This won't consider null environments in the screenshots.
Tests
I have only tested this on the Harvey application, since this is the only app that I know has this implemented. I also tried a random assortment of titles with and without screenshots without any problems/crashes, though.