Put the release notes description label inside a Gtk.Grid #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainm23
approved these changes
Dec 17, 2024
lenemter
requested changes
Dec 17, 2024
lenemter
reviewed
Dec 17, 2024
alainm23
approved these changes
Dec 17, 2024
This is the same issue that we had for issues, but now for the description label itself. It seems that in a Gtk.Box with wrapped labels will not do its height correctly, if there are grids abound. Putting the label inside a Gtk.Grid will make it also respect the natural height and will fix another set of problems found in other description labels.
Co-authored-by: Leo <lenemter@gmail.com>
edwood-grant
force-pushed
the
italocapasso/issue-2224-round-2
branch
from
ff7860b to
dba0ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short summary
This fixes #2233
This is the same issue that we had for issues, but now for the description label itself. It seems that in a
Gtk.Boxwith wrapped labels will not do its height correctly, if there are grids abound.Putting the label inside a
Gtk.Gridwill make it also respect the natural height and will fix another set of problems found in other description labels.Another change in this PR was a small refactor to compartmentalize each widget creation in its own method. This is just for organization and refactoring purposes only.Edit: Having methods within the constructor is not preferred, so this was set back to how it was before.
Tests
Here are tests made on the notified app issues:
Nimbus
Before:
After:
Journaler
Before:
After:
Reco
Before:
After: