Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Gtk4 Prep #2287

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Sidebar Gtk4 Prep #2287

merged 8 commits into from
Aug 23, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Aug 15, 2023

Starting over based on changes from #2082

I think this is The Least™ to make sure these don't subclass ListBox without any errors or warnings in terminal etc

SidebarInterface, SidebarWindow

  • Remove unused remove_item_by_id

SidebarItemInterface

  • subclasses Object rather than Gtk.Widget

SidebarListInterface

  • subclasses Object rather than Gtk.Widget
  • remove unused remove_bookmark_by_uri
  • Use Gtk.ListBoxRow instead of SidebarItemInterface where possible to avoid issues with pointers/casting
  • Misc code style

BookmarkListBox, DeviceListBox, NetworkListBox

  • Subclass Box, ListBox is a child
  • Use Gtk.ListBoxRow instead of SidebarItemInterface where possible to avoid issues with pointers/casting
  • Misc code style

@danirabbit danirabbit mentioned this pull request Aug 15, 2023
@danirabbit danirabbit marked this pull request as ready for review August 15, 2023 19:57
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reduce the diff by reverting changes to the clear () function. Otherwise everything seems to work as before.

@jeremypw
Copy link
Collaborator

Holding until after release of version 6.5.0

@jeremypw jeremypw enabled auto-merge (squash) August 23, 2023 14:52
@jeremypw jeremypw merged commit 580aefc into main Aug 23, 2023
4 checks passed
@jeremypw jeremypw deleted the danirabbit/sidebar-boxsubclass branch August 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants