Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search improvements Part1: Default to search mode when focussed #2467

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Search improvements Part1: Default to search mode when focussed #2467

merged 3 commits into from
Sep 3, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Sep 1, 2024 •
edited
Loading

TEST IN X ONLY

Search window is broken in Wayland and needs replacing with (e.g.) Popover to fix.

  • Ensures that the search icon shows after pressing <Ctrl>F
  • Ensures placeholder shows when no text and remains in search mode (or switches to it)
  • Simplifies switching between search and navigate modes

Extracted from #2403 where not related to use of Popover.

@jeremypw jeremypw marked this pull request as ready for review September 1, 2024 19:48
danirabbit
danirabbit approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a lot simpler and works as expected afaict

@danirabbit danirabbit merged commit 42e0eb9 into main Sep 3, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/fix-search branch September 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremypw @danirabbit