Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PopupMenuBuilder: use GLib.Action for MountableRow #2470

Merged
merged 10 commits into from
Sep 4, 2024
Merged

PopupMenuBuilder: use GLib.Action for MountableRow #2470

merged 10 commits into from
Sep 4, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 3, 2024 •
edited
Loading

Initial work to start porting PopupMenuBuilder to use GLib.Actions. Based on work in #2082

Remove unused add_mount

@danirabbit danirabbit changed the title PopupMenuBuilder: use GLib.Action PopupMenuBuilder: use GLib.Action for device menuitems Sep 3, 2024
@danirabbit danirabbit changed the title PopupMenuBuilder: use GLib.Action for device menuitems PopupMenuBuilder: use GLib.Action for MountableRow Sep 3, 2024
@danirabbit danirabbit marked this pull request as ready for review September 3, 2024 21:50
@danirabbit danirabbit requested a review from a team September 3, 2024 21:50
jeremypw
jeremypw approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a new warning when about mapping to a non-toplevel window when running under Wayland (but not X11) - but this will probably disappear when converted to GLib.Menu so not worth investigating. It does not affect functionality.

@jeremypw jeremypw merged commit df0e95e into main Sep 4, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/popupmenubuilder-actions branch September 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw