Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationStack: Check if notification was already shown #1748

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

lenemter
Copy link
Member

After a reboot i cannot reproduce #1783 anymore, so this is my first wild guess on what might be going on.

@lenemter lenemter requested a review from a team August 29, 2023 13:37
@lenemter
Copy link
Member Author

@TomiOhl Can you check if it makes any difference on your machine please? I can give instructions if you need them.

@TomiOhl
Copy link
Contributor

TomiOhl commented Aug 29, 2023

@TomiOhl Can you check if it makes any difference on your machine please? I can give instructions if you need them.

I've also rebooted and currently I cannot reproduce it either 😅 Not sure what triggers the behavior. Would be useful to know in order to test properly.
Instructions: the ones in the readme are up-to-date?

@lenemter
Copy link
Member Author

Instructions: the ones in the readme are up-to-date?

Yes, they are. You can quickly install build dependencies using sudo apt build-dep gala

@TomiOhl
Copy link
Contributor

TomiOhl commented Aug 29, 2023

Cool, thanks for the tip. I can try it on my other laptop in the evening (approx. 6h from now).

@TomiOhl
Copy link
Contributor

TomiOhl commented Aug 30, 2023

So I've tried to reproduce the issue on my other laptop, but I couldn't do so neither on this branch nor on master. Would be useful to know what causes it really.
Things that I haven't tried here but do cause other issues in gala:

  • multiple displays
  • different aspect ratios

I did get the issue again on my work laptop today though. I don't really want to use it for testing but right now I feel like that would be the easiest thing that I could do on my end

@lenemter
Copy link
Member Author

I think we should merge this branch, since the change is very small and won't introduce any new issues, but might fix the notifications issue.

@lenemter lenemter mentioned this pull request Oct 25, 2023
@danirabbit danirabbit enabled auto-merge (squash) October 26, 2023 18:09
@danirabbit danirabbit merged commit a582033 into master Oct 26, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/idk-what-im-doing branch October 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants