Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkspaceManager: Fixes and cleanup #1768

Merged
merged 8 commits into from
Oct 26, 2023
Merged

WorkspaceManager: Fixes and cleanup #1768

merged 8 commits into from
Oct 26, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Sep 29, 2023 •
edited
Loading

Fixes #506
Fixes #695

Changes:

  1. On boot there is now only a single "+" workspace
  2. If a window is removed from the second to last workspace and it becomes empty, it will become the "+" workspace

@lenemter lenemter requested a review from a team September 29, 2023 12:52
@lenemter lenemter marked this pull request as ready for review September 29, 2023 12:52
danirabbit
danirabbit approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good

@danirabbit danirabbit merged commit 11c3125 into master Oct 26, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/workspacemanager-improvements branch October 26, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong workspaces behavior After login there is always 2 unpopulated workspaces open.
2 participants
@lenemter @danirabbit