Use WindowPositioner for panel positions #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
commented
Nov 3, 2024
src/ShellClients/PanelWindow.vala
Outdated
|
|
||
| window_positioner = new WindowPositioner (display, window, WindowPositioner.Position.from_anchor (anchor)); | ||
|
|
||
| notify["anchor"].connect (() => { |
There was a problem hiding this comment.
Btw the notify here is also useful because we don't want the handler to run the first time it's set (i.e. with the constructor).
|
I've been running this quite a bit now so it should be ready for review and testing. |
lenemter
requested changes
Dec 7, 2024
lenemter
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also allow to do a bit better architecture in #2103 where instead of changing barriers on setting hide mode we change on changing anchor which is the actual reason we would need to resetup.