Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternalUtils: Introduce wait_for_window_actor utility #2178

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Dec 19, 2024

Tries to achieve the same as #2176 without introducing a whole class just to wait for something. Instead we add a function to internalutils that takes a callback which it will call immediately if the windowactor is already available or wait a single idle for it.

@leolost2605 leolost2605 requested review from lenemter and a team December 19, 2024 14:01
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenemter lenemter merged commit 6a90680 into main Dec 19, 2024
5 checks passed
@lenemter lenemter deleted the leolost/internal-utils-wait-for-window-actor branch December 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants