-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to copy code snippet #56
Conversation
Co-authored-by: Antolius <josip.antolis@protonmail.com>
I won't merge in case there is design feedback, but the code looks good |
Co-authored-by: Danielle Foré <danielle@elementary.io>
@danirabbit Thank you for your detailed reviews! I addressed your comments. I don't have PCs with a touch screen so I can't test if the copy button get visible on these devices. Could you test that if you have one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that works for me! Can access the button with mouse, keyboard, and touch. Nice job :)
Fixes #5
Closes #31
Differences from the previous PR:
edit-copy
icon, so that we can also use it to tell users the text being copiedTimeout.add_once ()
I tried the button to be similar to the one written in the Prior Art of #5, but I'm not familiar with CSS so design feedback is especially appreciated.