-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apps: Redesign system-software-install #1284
Conversation
Initial explorations based off discussion in #1151 . I lean towards following |
That little truck is 👨🍳👌💋 |
Yeah the truck is adorable. I would definitely be really careful about designing at smaller sizes though. This icon is very unlikely to be used at 128px. It's probably more likely to be used at 48px in dialogs, 32px in lists, and there's a couple cases of like 16px symbolic as bullets |
7d4d6c9
to
3c327b6
Compare
I went ahead and did all of the sizes to keep consistency with the other apps, even if they're unlikely to be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sorry for taking a while to follow up here. This is a super cute little icon. I love that it shows a kind of more "industrial" implication of the package manager versus the app store as well.
My only major complaint is that its much smaller than other icons at its size and where the baseline of the icon is seems to be higher. See for example here:
Another thing to watch out for is how highlight gradients fall over the top edges of objects. Look at this for example. You can see how the gradient stop should match up with where that corner stop is:
Oh oops, apparently 'temporary' means permanent. Let me fix that then it will be ready for review again |
Actually ready for re-review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! The smallest sizes are especially cute. Just a few comments here
The border color here is significantly different from the archive file type icon:
when you have a rounded shape that contains another rounded shape, make sure that you adjust the radii so that there's consistent spacing around the edges. See the red circle in the first shape and how there's a lot of extra gap compared to the shape on the right?
Also for highlight gradients you want the outer stops to be contained inside the stroke and the inner stops should line up with the radius handle of the shape basically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with it through all the rounds of feedback! These are very cute icons, good job :)
Related #1151
Redesign
system-software-install
to separate it from AppCenter branding