Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps: Redesign system-software-install #1284

Merged
merged 27 commits into from
Sep 10, 2024

Conversation

wpkelso
Copy link
Member

@wpkelso wpkelso commented May 29, 2024

Related #1151

Redesign system-software-install to separate it from AppCenter branding

@wpkelso
Copy link
Member Author

wpkelso commented May 29, 2024

Explorations

Initial explorations based off discussion in #1151 . I lean towards following warehouse, but would appreciate your input here @danirabbit

@micahilbery
Copy link
Member

That little truck is 👨‍🍳👌💋

@danirabbit
Copy link
Member

Yeah the truck is adorable. I would definitely be really careful about designing at smaller sizes though. This icon is very unlikely to be used at 128px. It's probably more likely to be used at 48px in dialogs, 32px in lists, and there's a couple cases of like 16px symbolic as bullets

@wpkelso wpkelso force-pushed the system-software-refresh branch from 7d4d6c9 to 3c327b6 Compare June 5, 2024 18:02
@wpkelso wpkelso marked this pull request as ready for review June 5, 2024 18:03
@wpkelso
Copy link
Member Author

wpkelso commented Jun 5, 2024

I went ahead and did all of the sizes to keep consistency with the other apps, even if they're unlikely to be used

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry for taking a while to follow up here. This is a super cute little icon. I love that it shows a kind of more "industrial" implication of the package manager versus the app store as well.

My only major complaint is that its much smaller than other icons at its size and where the baseline of the icon is seems to be higher. See for example here:

Screenshot from 2024-06-24 08 14 57

Another thing to watch out for is how highlight gradients fall over the top edges of objects. Look at this for example. You can see how the gradient stop should match up with where that corner stop is:

Screenshot from 2024-06-24 08 18 05

@wpkelso wpkelso requested a review from danirabbit July 1, 2024 19:04
@wpkelso
Copy link
Member Author

wpkelso commented Jul 17, 2024

Oh oops, apparently 'temporary' means permanent. Let me fix that then it will be ready for review again

@wpkelso
Copy link
Member Author

wpkelso commented Jul 22, 2024

Actually ready for re-review now

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! The smallest sizes are especially cute. Just a few comments here

The border color here is significantly different from the archive file type icon:

Screenshot from 2024-08-16 15 33 06

when you have a rounded shape that contains another rounded shape, make sure that you adjust the radii so that there's consistent spacing around the edges. See the red circle in the first shape and how there's a lot of extra gap compared to the shape on the right?

Screenshot from 2024-08-16 15 37 43

Also for highlight gradients you want the outer stops to be contained inside the stroke and the inner stops should line up with the radius handle of the shape basically

@wpkelso wpkelso requested a review from danirabbit August 17, 2024 20:44
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with it through all the rounds of feedback! These are very cute icons, good job :)

@danirabbit danirabbit enabled auto-merge (squash) September 10, 2024 19:19
@danirabbit danirabbit merged commit 15aa184 into elementary:main Sep 10, 2024
3 checks passed
@wpkelso wpkelso deleted the system-software-refresh branch September 10, 2024 19:21
@wpkelso wpkelso mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants