Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Refresh symbolic window actions #1295

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

wpkelso
Copy link
Member

@wpkelso wpkelso commented Jul 30, 2024

Addresses #928 by unifying the size and language of the window controls.

Previously, window-close used a baseline of 4px, window-minimize used a border of 3px, and window-maximize/window-restore both used 4px borders. This mostly unifies to 2px border, with window-close now using a 3px border because 2px felt slightly large in comparison to the others

Additionally, window-minimize used an older shape language and color, so that has been unified as well.

In context:
image
image

image
image

@wpkelso wpkelso changed the title WIP: Unify symbolic window actions WIP: Refresh symbolic window actions Aug 2, 2024
@wpkelso wpkelso changed the title WIP: Refresh symbolic window actions Actions: Refresh symbolic window actions Aug 2, 2024
@wpkelso wpkelso requested a review from danirabbit August 2, 2024 17:13
@wpkelso wpkelso marked this pull request as ready for review August 2, 2024 17:13
@wpkelso wpkelso marked this pull request as draft August 13, 2024 20:37
@wpkelso wpkelso marked this pull request as ready for review August 27, 2024 22:33
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes the close button too big. Especially apparent here:

Screenshot from 2024-09-10 16 15 51

Seems way larger than the plus icon

@wpkelso
Copy link
Member Author

wpkelso commented Sep 16, 2024

Slightly decreased the size of the arms to find a middle-ground between the two sizes, though I think it may have caused some pixel-fitting issues :(
image
image

Extra reference of what size is currently like on main, for the sake of it:
image

@wpkelso wpkelso requested a review from danirabbit September 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants