Add Notifications settings #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
reviewed
Oct 2, 2024
There was a problem hiding this comment.
I had to fake a permission setting for notifications from the PermissionStore - is this expected? I am running in a VM but the other permissions settings were constructed OK.
If I faked a "no" permission then the notification permission setting was constructed OK and appeared above the "Advanced System Settings" sections as indicated by the screenshot.
If this is dependent on changes in other repos to actually work then I am prepared to approve.
|
@jeremypw ah no it should just work. It might be that your VM is new and doesn't have apps sending notifications yet? A good way to test would be to use ASHPD to send a notification and then it should appear there automatically |
jeremypw
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps don't set
x-gnome-uses-notificationsso they can't be controlled even if they do use the notifications portal. Adds a setting for notifications that uses PermissionStore so we can still disable notifications for those apps