Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisplayWidget: Gtk4 prep #368

Merged
merged 3 commits into from
Jan 10, 2024
Merged

DisplayWidget: Gtk4 prep #368

merged 3 commits into from
Jan 10, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 8, 2024 •
edited
Loading

Screenshot from 2024-01-08 15 07 24

  • Use event controllers
  • explicit margins
  • code style
  • Use Granite.SwitchModelButton in a popover instead of label and switch
  • Use Granite.HeaderLabel and set mnemonic widgets for a11y

@danirabbit danirabbit requested a review from a team January 8, 2024 23:12
@danirabbit @lenemter
Update src/Widgets/DisplayWidget.vala
7c659f3 
Co-authored-by: Leo <lenemter@gmail.com>
@danirabbit danirabbit requested a review from lenemter January 9, 2024 16:00
@danirabbit @lenemter
Update src/Widgets/DisplayWidget.vala
ff51262 
Co-authored-by: Leo <lenemter@gmail.com>
@danirabbit danirabbit requested a review from lenemter January 10, 2024 00:43
@lenemter lenemter merged commit 4aa3dfe into master Jan 10, 2024
4 checks passed
@lenemter lenemter deleted the danirabbit/displaywidget-gtk4prep branch January 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @lenemter