Port to GTK4 #369
Port to GTK4 #369
Conversation
There was a problem hiding this comment.
All the layout/syntax changes look good.
However the display widget popover does not close when the "Apply" button is pressed or the background clicked - only when "Esc" is pressed. Then pressing "Apply" applies the changes. This differs from the behaviour of master.
There is also a layout issue when one of the displays is rotated, which is not present in master, the settings menu button is misplaced:
|
@jeremypw fixed the button placement issue, but I also noticed since in GTK 4 the button is actually a child widget of MenuButton and MenuButton isn't a button subclass that it breaks some of the CSS here. This should be fixed with #379 so I'll leave that up to you if you think that should be merged first. It looks like the popover's autohide gets broken when the displaywidget changes, so I have it popdown now when one of these breaking changes would occur. Is that an okay solution? I'm not sure how to solve it otherwise |
|
@danirabbit Could you resolve the conflicts please? |
|
@jeremypw done! |
#379 will solve some new warnings that come in GTK 4 but it's not strictly necessary to merge it first