Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use daemon to show display labels #372

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Use daemon to show display labels #372

merged 5 commits into from
Feb 21, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jan 22, 2024 •
edited
Loading

Complement elementary/gala#1840

  • This has to be tested with two monitors again: Currently pressing detect displays breaks the whole thing

Closes #371
Fixes #352

@leolost2605 leolost2605 mentioned this pull request Jan 22, 2024
Closed
@leolost2605 leolost2605 changed the title Remove display window but use daemon Use daemon to show display labels Jan 22, 2024
@leolost2605 leolost2605 mentioned this pull request Feb 18, 2024
Merged
@leolost2605 leolost2605 marked this pull request as ready for review February 20, 2024 09:32
danirabbit
danirabbit approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! I can confirm it works with multiple displays. Great work 🎉

@danirabbit danirabbit merged commit eb6bd00 into master Feb 21, 2024
4 checks passed
@danirabbit danirabbit deleted the leolost/remove-display-window-daemon branch February 21, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display name tags positioned incorrectly under Wayland
3 participants
@leolost2605 @danirabbit @lenemter