Move drag gesture to overlay; simplify #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danirabbit I think this is worth a look now - I have tested as best I can using dummy widgets faking three monitors. I assume that the user drags the displays into an approximately legal position at least - in which the displays should snap together. Otherwise the displays remain where the use placed then and the "Apply" button is insensitive, |
danirabbit
previously approved these changes
Feb 22, 2024
danirabbit
approved these changes
Feb 22, 2024
danirabbit
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids flickering while dragging, deals with three monitors better, Apply button insensitive unless displays legally connected.