Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisplaysOverlay: put overlay in a box #378

Merged
merged 1 commit into from
Feb 23, 2024
Merged

DisplaysOverlay: put overlay in a box #378

merged 1 commit into from
Feb 23, 2024

Conversation

danirabbit
Copy link
Member

Can't subclass overlay in Gtk4

@danirabbit danirabbit requested a review from a team February 22, 2024 21:08
jeremypw
jeremypw approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and does not affect appearance/behaviour

@jeremypw jeremypw merged commit 126f397 into master Feb 23, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/displaysoverlay-box branch February 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw