Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs use present and response #369

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Dialogs use present and response #369

merged 2 commits into from
Jan 10, 2024

Conversation

danirabbit
Copy link
Member

Gtk4 prep.

  • No run () in gtk4.
  • run() sets modal, so we have to do it manually now.
  • No window-position in GTK4 so fix that while we're here

@danirabbit danirabbit requested a review from a team January 8, 2024 20:18
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeremypw jeremypw merged commit 54c3b18 into master Jan 10, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/dialogpresent branch January 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants