Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPNPage: rewrite connection forget #388

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

danirabbit
Copy link
Member

Moves forget buttons into the VPN row iteself, in line with the design of other lists. Review might be easier with hide whitespace

@danirabbit danirabbit requested a review from a team January 18, 2024 22:17
@jeremypw
Copy link
Collaborator

@danirabbit Could you resolve the conflict please?

@danirabbit
Copy link
Member Author

@jeremypw done :)

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected.

@jeremypw jeremypw merged commit c73e883 into master Jan 19, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/vpn-rewriteforget branch January 19, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants