New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSetttingsView: redesign #101

Merged

jeremypw merged 1 commit into main from danirabbit/redesign

Mar 7, 2024

Member

danirabbit commented Mar 6, 2024

Use GraniteHeaderLabel for options and stack options vertically so the view is more responsive
Break up cards into modular pieces and position in CSS. Supports RTL now
Use icon from the system for sound and color it for higher contrast
Use selected_bg_color to prepare for arbitrary accent colors support via freedesktop accent portal
Apply style provider to display, only non-deprecated use of Gtk.StyleContext
Set mnemonic widget for screen reader


          AppSetttingsView: redesign

629e4e9

danirabbit requested a review from a team

March 6, 2024 21:55

jeremypw approved these changes

View reviewed changes

Collaborator

jeremypw left a comment

Improved appearance, code looks good (no functional changes).

jeremypw merged commit 92ae212 into main

3 of 4 checks passed

jeremypw deleted the danirabbit/redesign branch

March 7, 2024 17:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet