Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WallpaperContainer: Gtk4 prep #376

Merged
merged 3 commits into from
Dec 3, 2023
Merged

WallpaperContainer: Gtk4 prep #376

merged 3 commits into from
Dec 3, 2023

Conversation

danirabbit
Copy link
Member

  • Move margins into CSS and add a comment explaining why they are set in two places
  • Remove unnecessary width/height request
  • Replace grid with box
  • Use granite style class constant
  • Use child property
  • code style
  • fix deprecated metadata.get_tag_string
  • Combine single-use method

@danirabbit danirabbit requested a review from a team November 9, 2023 18:52
@danirabbit danirabbit enabled auto-merge (squash) December 3, 2023 17:52
@danirabbit danirabbit merged commit 132c1dc into master Dec 3, 2023
4 checks passed
@danirabbit danirabbit deleted the danirabbit/wallpapercontainer-moregtk4prep branch December 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok