Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dim wallpaper setting to appearance #401

Merged
merged 2 commits into from
May 18, 2024
Merged

Move dim wallpaper setting to appearance #401

merged 2 commits into from
May 18, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 18, 2024 •
edited
Loading

This makes more sense with #399

Peek.2024-05-18.10-33.mp4

@danirabbit danirabbit requested a review from a team May 18, 2024 17:26
zeebok
zeebok approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noted while doing the other PR that the spacing between the dim label and switch was like 0 on the wallpaper page. This fixes that! Though oddly in my test I didn't have that new paned style like in your video.

Look good though!

@danirabbit
Copy link
Member Author

Haha yeah it was kind of janky. Excited to get this cleaned up!

The paned style is in #400 :)

@danirabbit danirabbit merged commit d0d87b6 into main May 18, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/mv-dimwallpaper branch May 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok