Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance: clean up redundant labels #402

Merged
merged 2 commits into from
May 19, 2024
Merged

Appearance: clean up redundant labels #402

merged 2 commits into from
May 19, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 18, 2024 •
edited
Loading

Try to clean up some overzealous explanation text.

  • Every setting in this app is a system setting so it feels weird to explicitly explain that
  • The page description already calls out that apps may ignore these settings so no need to repeat that for each section
  • It doesn't feel like the "Style" header really adds value on top of the main "Appearance" header here

AFTER

Screenshot from 2024-05-18 14 37 21

BEFORE

Screenshot from 2024-05-18 14 38 06

@danirabbit danirabbit requested review from a team May 18, 2024 21:39
@danirabbit danirabbit merged commit 8d55c69 into main May 19, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/rm-redundantlabels branch May 19, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @lenemter