Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategoryView: absorb headerbar #279

Merged
merged 8 commits into from
Mar 21, 2024
Merged

CategoryView: absorb headerbar #279

merged 8 commits into from
Mar 21, 2024

Conversation

@danirabbit danirabbit force-pushed the danirabbit/flatten-part2 branch from 490ba57 to e7fd714 Compare January 23, 2024 21:35
@danirabbit danirabbit marked this pull request as ready for review March 21, 2024 17:10
@danirabbit danirabbit requested a review from leolost2605 March 21, 2024 18:10
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get the window controls to the same height as on the setting pages etc.? IMHO it currently looks a bit "stretched" with them being quite far down 🤷

@danirabbit
Copy link
Member Author

@leolost2605 can you post a screenshot? It looks the same here

@leolost2605
Copy link
Member

image
Compared to
image

@danirabbit
Copy link
Member Author

danirabbit commented Mar 21, 2024

@leolost2605 oh wow haha. Can you make sure you're on io.elementary.stylesheet 7.3.0+r524+pkg338dailyubuntu24.04.1?

Also you might need to run ninja clean to make sure to rebuild CSS in this branch

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ninja clean fixed it, sorry 😬

But let's gooo 🎉

@danirabbit danirabbit merged commit 9bc60e2 into main Mar 21, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/flatten-part2 branch March 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants