SettingsPage: add with_avatar option #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
SettingsPage works with the linked plug PR and with the bluetooth plug (changing icon). SettingsSidebarRow needs testing with avatar but code looks good.
I was surprised the property bindings worked despite no explicit casting of display_widget to different types (Image, Avatar) but there did not seem to be any compilation or terminal warnings so I guess it is OK.
|
@danirabbit Needs conflict resolved. |
|
@jeremypw yeah I wondered if it might need to be casted as well, but seems to work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only custom header widget we ever use is an Avatar, so add an option for that instead of the
display_widgetoption which doesn't really work and isn't usedCan test with elementary/switchboard-plug-parental-controls#187
Theoretically SettingsSidebarRow is also set up in this branch, but it'll take more work to make a branch to test that with so I'm assuming I'll need to follow up there to make it work properly