Synchronise settings and global "is-powered" state #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
reviewed
Apr 8, 2023
Co-authored-by: Leo <lenemter@gmail.com>
|
Fixing CI ... |
|
This was found to reintroduce #192 😞 so converted back to draft. I am not sure this PR is essential anyway - manually changing the "bluetooth-enabled" setting is unlikely (and unwise) anyway. |
added 9 commits
April 8, 2023 19:12
|
Need to revert unused change. |
|
Code looks good, I just need to test! |
|
@zeebok Thanks for reviewing! Remember that for everything to work properly you need to install the corresponding switchboard plug PR as well 😉 |
zeebok
approved these changes
Jun 5, 2023
|
Blocking merge until other elementary/switchboard-plug-bluetooth#206 approved - they can then be merged at the same time. |
|
Oops that is totally my bad, I forgot to approve the other one! Should be all set now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging this, it is necessary to merge elementary/switchboard-plug-bluetooth#206 to allow switchboard to continue to sync properly.
After merging both PRs, all four switches affecting the Bluetooth power state should remain synchonised and stable.
To test:
Check that changing the Bluetooth enabled state by any of the switches in Wingpanel, Switchboard or
io.elementary.desktop.wingpanel.bluetooth.bluetooth-enabledresults in the other states changing accordingly.Suspend and change the Bluetooth enabled state using the greeter wingpanel. This should operate stably. On reawakening, the changed state should be reflected in the session wingpanel.
Restart and check greeter Bluetooth indicator works as expected