Deep clean the .erl files generated by yecc/leex. #10153
Conversation
vgsantoniazzi
force-pushed
the
deep-clean-build-deps
branch
from
b35a79e to
e78c866
Compare
When cleaning with --deps flag, iterate over dependencies and remove generated .erl files. This feature was discussed in elixir-lang#8262.
vgsantoniazzi
force-pushed
the
deep-clean-build-deps
branch
from
e78c866 to
032da45
Compare
| deps_paths = | ||
| Mix.Project.deps_paths() | ||
| |> Map.values() | ||
| |> Enum.map(&Path.join(&1, "**/*.erl")) |
There was a problem hiding this comment.
Unfortunately we cannot simply remove all .erl files because we will remove source files for many erlang projects, that have .erl files in their deps. The implementation of this functionality needs to be tied to the Mix.Task.Compiler behaviour and it is likely quite more complex than this. :(
There was a problem hiding this comment.
An alternative could be to modify the compilers that output the .erl files either not to do that at all, our output them inside _build.
There was a problem hiding this comment.
What about removing .erl files that have their uncompiled version?
If the only way that you saw is going through the Mix.Task.Compiler I can try to do this.
There was a problem hiding this comment.
@michalmuskala I tried that back then but unfortunately I ran into major issues, I don't recall them right now. Modifying the compilers to not output the .erl files actually sounds great. It solves the problem altogether.
There was a problem hiding this comment.
Yeah, it will also be a fair bit of work, unfortunately. There are some limitations of the yecc and leex compilers themselves to work around to do this
|
Ok, based on the comments, this PR should not be forward. Thanks for reviewing it. |
When cleaning with --deps flag, iterate over dependencies and remove generated .erl files.
This feature was discussed in #8262.