Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to incoming NACK #100

Closed
wants to merge 5 commits into from
Closed

Respond to incoming NACK #100

wants to merge 5 commits into from

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Apr 15, 2024

No description provided.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Merging #100 (49b3e31) into master (945615b) will decrease coverage by 0.75%.
The diff coverage is 69.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   87.88%   87.13%   -0.75%     
==========================================
  Files          32       33       +1     
  Lines        1576     1625      +49     
==========================================
+ Hits         1385     1416      +31     
- Misses        191      209      +18     
Files Coverage Δ
lib/ex_webrtc/rtp_sender/nack_responder.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp_sender.ex 92.10% <76.92%> (-7.90%) ⬇️
lib/ex_webrtc/rtp_transceiver.ex 89.80% <85.71%> (-1.17%) ⬇️
lib/ex_webrtc/peer_connection.ex 82.55% <45.16%> (-1.29%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945615b...49b3e31. Read the comment docs.

@mickel8 mickel8 force-pushed the outbound-rtx branch 5 times, most recently from 7c951ba to a5e44d9 Compare April 17, 2024 09:20
@LVala LVala self-assigned this Apr 18, 2024
@LVala LVala mentioned this pull request Apr 19, 2024
54 tasks
@LVala LVala marked this pull request as ready for review April 19, 2024 11:19
@LVala
Copy link
Member

LVala commented Apr 19, 2024

Closing this PR in favour of a new one as Github does not allow changing the owner of a PR.

@LVala LVala closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants