Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup SRTP decryption #12

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Setup SRTP decryption #12

merged 3 commits into from
Nov 7, 2023

Conversation

LVala
Copy link
Member

@LVala LVala commented Nov 6, 2023

No description provided.

@LVala LVala self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #12 (66f3c1b) into master (1aeef5b) will decrease coverage by 2.82%.
Report is 2 commits behind head on master.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   74.12%   71.30%   -2.82%     
==========================================
  Files           9        9              
  Lines         344      359      +15     
==========================================
+ Hits          255      256       +1     
- Misses         89      103      +14     
Files Coverage Δ
lib/ex_webrtc/peer_connection.ex 72.67% <0.00%> (-1.74%) ⬇️
lib/ex_webrtc/dtls_transport.ex 30.00% <6.66%> (-5.90%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeef5b...66f3c1b. Read the comment docs.

@LVala LVala requested a review from mickel8 November 6, 2023 11:05
{:ok, payload} ->
{:ok, dtls, payload}

{:error, reason} = err when reason in [:reply_old, :reply_fail] ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ignore all errors for now. Maybe just log warning so we see them

@LVala LVala merged commit d9aafde into master Nov 7, 2023
4 checks passed
@LVala LVala deleted the setup-srtp-decryption branch November 7, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants