Fix simulcast issues #121
Merged
Fix simulcast issues #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 87.50% 87.20% -0.31%
==========================================
Files 34 34
Lines 1721 1727 +6
==========================================
Hits 1506 1506
- Misses 215 221 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
Jun 24, 2024
lib/ex_webrtc/rtp_receiver.ex
Outdated
| @@ -213,8 +213,10 @@ defmodule ExWebRTC.RTPReceiver do | |||
| @spec get_stats(receiver(), non_neg_integer()) :: [map()] | |||
| def get_stats(receiver, timestamp) do | |||
| Enum.map(receiver.layers, fn {rid, layer} -> | |||
| id = if(rid == nil, do: receiver.track.id, else: "#{receiver.track.id}, rid: #{rid}") | |||
There was a problem hiding this comment.
I would favor using : and no spaces as puting spaces and commas in id isn't a common practice
Suggested change
| id = if(rid == nil, do: receiver.track.id, else: "#{receiver.track.id}, rid: #{rid}") | |
| id = if(rid == nil, do: receiver.track.id, else: "#{receiver.track.id}:#{rid}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
send_plinot working with simulcastinbound_rtpsections inget_statsridsfield toMediaStreamTrack, which contains negotiated RIDs