Fix set_remote_description failing on description with rejected m-lines
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 88.31% 88.35% +0.03%
==========================================
Files 36 36
Lines 1891 1897 +6
==========================================
+ Hits 1670 1676 +6
Misses 221 221
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sgfn
approved these changes
Aug 5, 2024
lib/ex_webrtc/sdp_utils.ex
Outdated
Comment on lines
21
to
22
| case length(sdp.media) do | ||
| 0 -> {:error, :empty_sdp} |
There was a problem hiding this comment.
[nitpick] Enum.empty? would work in constant time
mickel8
approved these changes
Aug 6, 2024
lib/ex_webrtc/peer_connection.ex
Outdated
|
|
||
| {ice_ufrag, ice_pwd} -> | ||
| :ok = state.ice_transport.set_remote_credentials(state.ice_pid, ice_ufrag, ice_pwd) | ||
| end | ||
|
|
||
| for candidate <- SDPUtils.get_ice_candidates(sdp) do |
There was a problem hiding this comment.
I think I would move this inside case, when we have ICE credentials, even though that ICE will ignore remote candidates when it does not have them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
set_remote_descriptionwon't try to use ICE credentials from rejected m-lines (and subsequently, won't fail if ICE credentials in rejected m-lines differ from credentials in active m-lines),set_remote_descriptionwon't fail when all of the m-lines are rejected (so there's no valid ICE credentials in the description). In such case, it will either not connect (for the first description) or use credentials from previous descriptions (for the subsequent descriptions)Other elements of rejected m-lines might need to be ignored as well (like MIDs, fingerprints, etc.), but it seems like browsers include them anyway, so for now this fix seems to be enough.
Close #144