Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle other retransmit case in DTLSTransport #148

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sgfn
Copy link
Member

@sgfn sgfn commented Aug 6, 2024

Closes #137

This isn't really a fix per se, but at least DTLSTransport won't crash anymore

@sgfn sgfn requested a review from mickel8 August 6, 2024 14:20
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.30%. Comparing base (15eee61) to head (bccbc7f).

Files Patch % Lines
lib/ex_webrtc/dtls_transport.ex 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   88.40%   88.30%   -0.10%     
==========================================
  Files          36       36              
  Lines        1897     1899       +2     
==========================================
  Hits         1677     1677              
- Misses        220      222       +2     
Files Coverage Δ
lib/ex_webrtc/dtls_transport.ex 85.12% <0.00%> (-1.44%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15eee61...bccbc7f. Read the comment docs.

@LVala LVala merged commit b286b03 into master Aug 7, 2024
3 checks passed
@LVala LVala deleted the fix/dtls-transport-crash branch August 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DTLS transport crash on message :retransmit
3 participants