Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic dispatch for (de)payloaders #152

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

sgfn
Copy link
Member

@sgfn sgfn commented Aug 8, 2024

No description provided.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.57%. Comparing base (fa717fa) to head (9b1c327).

Files Patch % Lines
lib/ex_webrtc/rtp/depayloader.ex 0.00% 7 Missing ⚠️
lib/ex_webrtc/rtp/payloader.ex 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           sgfn/payloader-behaviour     #152      +/-   ##
============================================================
- Coverage                     88.21%   87.57%   -0.65%     
============================================================
  Files                            36       38       +2     
  Lines                          1893     1907      +14     
============================================================
  Hits                           1670     1670              
- Misses                          223      237      +14     
Files Coverage Δ
lib/ex_webrtc/rtp/depayloader.ex 0.00% <0.00%> (ø)
lib/ex_webrtc/rtp/payloader.ex 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa717fa...9b1c327. Read the comment docs.

@sgfn sgfn marked this pull request as ready for review August 8, 2024 11:49
@sgfn sgfn merged commit b142d04 into sgfn/payloader-behaviour Aug 8, 2024
1 check passed
@sgfn sgfn deleted the sgfn/payloader-dynamic-dispatch branch August 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant