New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps and examples #168

Merged

mickel8 merged 1 commit into master from deps

Sep 23, 2024

Member

mickel8 commented Sep 23, 2024

This PR:

update deps in ex_webrtc and example apps
handles :EXIT message from PeerConnection - Bandit seems to trap exits so when our PeerConnection goes down, it won't bring PeerHandler process down. In most cases, PeerHandler is terminated anyway as WS closes on the other hand but...
fixed two obsoleted functions from JB


          Update deps and examples

52853d7

mickel8 marked this pull request as ready for review

September 23, 2024 13:34

mickel8 requested a review from sgfn

September 23, 2024 13:34

sgfn approved these changes

View reviewed changes

examples/save_to_file/lib/save_to_file/peer_handler.ex

    
            @@ -83,13 +83,21 @@ defmodule SaveToFile.PeerHandler do
          
                    :video -> state.video_buffer

                    :audio -> state.audio_buffer

                  end

                  |> JitterBuffer.handle_timer()

                  |> JitterBuffer.handle_timeout()

Member

sgfn Sep 23, 2024

oops, sorry bout that

mickel8 merged commit f985c68 into master

3 checks passed

mickel8 deleted the deps branch

September 23, 2024 15:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet