Create transceivers on set_remote_description #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
rtp-transceiver
branch
2 times, most recently
from
c28efe0
to
addb72f
Compare
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
mickel8
force-pushed
the
rtp-transceiver
branch
7 times, most recently
from
2d395d8
to
a1ed9a1
Compare
mickel8
force-pushed
the
rtp-transceiver
branch
from
a1ed9a1
to
138d00f
Compare
LVala
approved these changes
Oct 23, 2023
Comment on lines
+321
to
+323
| for track <- new_remote_tracks do | ||
| notify(state.owner, {:track, track}) | ||
| end |
There was a problem hiding this comment.
I suppose you know that and this is only temporary, but I believe this notification should appear when only tracks are negotiated.
There was a problem hiding this comment.
Now we accept everything :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely not perfect and for sure bugged but maybe this can be a base for further work.
The idea is that we iterate over mlines in SDP, we try to find a transceiver for a given mline, if it exists we potentially update its configuraiton. If it doesn't exist we create a new one. At the end we compare previous transceivers with new transceivers and try to find new MediaStreamTracks