Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention revalidation function cleanup and refactoring #3731

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Jan 21, 2024

This includes removing the plain text box (other than quick edit)

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (e6739ca) 27.81% compared to head (8060f08) 28.02%.
Report is 1 commits behind head on development.

Files Patch % Lines
sources/ElkArte/Modules/Drafts/Display.php 0.00% 27 Missing ⚠️
.../ElkArte/Mentions/MentionType/Event/Mentionmem.php 0.00% 9 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3731      +/-   ##
=================================================
+ Coverage          27.81%   28.02%   +0.21%     
+ Complexity         16457    16454       -3     
=================================================
  Files                424      424              
  Lines              82933    82919      -14     
=================================================
+ Hits               23065    23242     +177     
+ Misses             59868    59677     -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Spuds added 5 commits January 21, 2024 17:37
…errors

that t.slice was not a function due to data being passed that was not a string.
I'd like to just remove this :P but its needed for quick edit and adding a mention
The plaintext version of mentions and draft were quite old and various other theme issues.  Easy to add back, but the supporting code just can't become dilapidated.  For most users this is just another confusing option.
@Spuds Spuds merged commit f35dc22 into elkarte:development Jan 22, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant