Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull setupMenuContext out to is own class with other menu items #3734

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Jan 23, 2024

Plus some general refactoring of crazy long functions/methods in theme

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (8060f08) 28.02% compared to head (7f6f2a7) 27.73%.
Report is 2 commits behind head on development.

Files Patch % Lines
sources/ElkArte/Menu/MenuContext.php 72.97% 30 Missing ⚠️
themes/default/Theme.php 85.45% 16 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3734      +/-   ##
=================================================
- Coverage          28.02%   27.73%   -0.30%     
- Complexity         16454    16467      +13     
=================================================
  Files                424      425       +1     
  Lines              82919    82983      +64     
=================================================
- Hits               23242    23018     -224     
- Misses             59677    59965     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

! some general refactoring of crazy long functions/methods
@Spuds Spuds merged commit 781f221 into elkarte:development Jan 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant