Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-browser compiler error display #2247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janwirth
Copy link

@janwirth janwirth commented Mar 16, 2022

Quick Summary: Fix: Error display breaks on long text - the left and right part of the source code is clipped.

SSCCE

string< = "..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................."

It looks like this and I can only scroll to the right:
image

  • Elm: 0.19.1
  • Browser: Version 99.0.4844.51 (Official Build) (arm64)
  • Operating System: OSX 12.0.1 (21A559)

@github-actions
Copy link

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

@@ -57,6 +57,9 @@ viewError error =
, style "white-space" "pre-wrap"
, style "background-color" "black"
, style "padding" "2em"
, style "box-sizing" "border-box"
, style "width" "100%"
, style "overflow" "scroll"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use "auto" so there’s no unnecessary scrollbar when there is no overflow?

The default on macOS is to draw scrollbars on top of content, and only show it when scrolling. By changing a system setting, you can make macOS behave like Windows and Linux, which is to let the scrollbars take space and always be visible.

The difference between scroll and auto is that if no scrolling is needed, scroll shows ugly disabled scrollbars while auto shows no scrollbars at all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@janwirth
Copy link
Author

Confirmed working in lamdera-next build offered by @supermario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants