Only divert href to app if there is an href for an anchor tag. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When it could be merged? |
|
Good question. I'm not sure exactly what Elm's open-source workflow is. |
|
This has to be fixed. And no attention for 1 year ? Like really ? it would be pretty much useless to use Elm if it is not ignoring anchor links. Not all code is coded. What if i use a markdown plugin ? |
|
@Skinney (Robin Heggelund Hansen) I hear 20% of your job is working on Elm. Maybe this PR would be a quick win? :) |
|
Commenting here to make some more noise and letting people know we care about this PR. :) |
|
What about merge? |
|
Pretty please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue raised at elm/browser#34 which appears to check out, when you take a look at the HTML specification.