AddCommittedToken was edited to avoid amount duplicate on Lockup

elys-network · Apr 30, 2024 · 62db5c6 · 62db5c6
1 parent 2c170e8
commit 62db5c6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/x/commitment/types/commitments.go b/x/commitment/types/commitments.go
@@ -51,7 +51,6 @@ func (c *Commitments) AddCommittedTokens(denom string, amount math.Int, unlockTi
 					li++
 					continue
 				} else if lockup.UnlockTimestamp == unlockTime {
-					c.CommittedTokens[i].Lockups[li].Amount = lockup.Amount.Add(amount)
 					return
 				} else {
 					break

diff --git a/x/commitment/types/commitments_test.go b/x/commitment/types/commitments_test.go
@@ -25,6 +25,15 @@ func TestCommitments_AddCommittedTokens(t *testing.T) {
 	require.Equal(t, commitments.CommittedTokens[0].Lockups[0].Amount.String(), "100")
 	require.Equal(t, commitments.CommittedTokens[0].Lockups[0].UnlockTimestamp, uint64(100))
 	require.Len(t, commitments.CommittedTokens[1].Lockups, 1)
+
+	commitments.AddCommittedTokens("lp/3", sdk.NewInt(1000), 100)
+	commitments.AddCommittedTokens("lp/3", sdk.NewInt(2000), 120)
+	commitments.AddCommittedTokens("lp/3", sdk.NewInt(3000), 130)
+
+	require.Equal(t, commitments.CommittedTokens[2].Lockups[0].Amount.String(), "1000")
+	require.Equal(t, commitments.CommittedTokens[2].Lockups[1].Amount.String(), "2000")
+	require.Equal(t, commitments.CommittedTokens[2].Lockups[2].Amount.String(), "3000")
+
 }
 
 func TestCommitments_WithdrawCommitedTokens(t *testing.T) {