Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(estaking): prevent reward to invalid delegations #1034

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

cosmic-vagabond
Copy link
Contributor

Description

What has Changed?

  • issues spotted on new TestNet that was causing swaps and bot close positions transactions to fail due to invalid delegations in commitment module
  • PR prevents invalid delegations from going through the reward process

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Deployment Notes

Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.

Screenshots and Videos

Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.05%. Comparing base (908aaac) to head (bb0a03e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   44.06%   44.05%   -0.01%     
==========================================
  Files         934      934              
  Lines       35438    35445       +7     
==========================================
+ Hits        15614    15615       +1     
- Misses      18526    18530       +4     
- Partials     1298     1300       +2     
Components Coverage Δ
leveragelp_transactions 80.06% <ø> (ø)
leveragelp_lifecycle 82.72% <ø> (ø)
leveragelp_keeper 85.41% <ø> (ø)
leveragelp_queries 8.94% <ø> (ø)
accountedpool_transactions 100.00% <ø> (ø)
accountedpool_lifecycle ∅ <ø> (∅)
accountedpool_queries 65.04% <ø> (ø)
amm_transactions 73.33% <ø> (ø)
amm_lifecycle 90.66% <ø> (ø)
amm_keeper 58.00% <ø> (ø)
amm_queries 44.31% <ø> (ø)
assetprofile_transactions 76.85% <ø> (ø)
assetprofile_lifecycle ∅ <ø> (∅)
assetprofile_keeper 80.00% <ø> (ø)
assetprofile_queries 60.00% <ø> (ø)
burner_transactions 0.00% <ø> (ø)
burner_lifecycle ∅ <ø> (∅)
burner_keeper 100.00% <ø> (ø)
burner_queries 62.01% <ø> (ø)
commitment_transactions 78.29% <ø> (ø)
commitment_lifecycle ∅ <ø> (∅)
commitment_keeper 86.17% <ø> (ø)
commitment_queries 32.46% <ø> (ø)
epochs_transactions ∅ <ø> (∅)
epochs_lifecycle 92.00% <ø> (ø)
epochs_keeper 84.61% <ø> (ø)
epochs_queries 26.78% <ø> (ø)
estaking_transactions 68.93% <ø> (ø)
estaking_lifecycle 82.60% <ø> (ø)
estaking_keeper 72.64% <ø> (ø)
estaking_queries 32.71% <14.28%> (-0.84%) ⬇️
incentive_transactions ∅ <ø> (∅)
incentive_lifecycle ∅ <ø> (∅)
incentive_keeper ∅ <ø> (∅)
incentive_queries ∅ <ø> (∅)
masterchef_transactions 86.85% <ø> (ø)
masterchef_lifecycle 74.87% <ø> (ø)
masterchef_keeper 100.00% <ø> (ø)
masterchef_queries 25.81% <ø> (ø)
oracle_transactions 27.27% <ø> (ø)
oracle_lifecycle 30.00% <ø> (ø)
oracle_keeper 61.11% <ø> (ø)
oracle_queries 12.73% <ø> (ø)
parameter_transactions 18.86% <ø> (ø)
parameter_lifecycle ∅ <ø> (∅)
parameter_keeper 75.00% <ø> (ø)
parameter_queries 57.14% <ø> (ø)
stablestake_transactions 83.20% <ø> (ø)
stablestake_lifecycle 100.00% <ø> (ø)
stablestake_keeper 90.47% <ø> (ø)
stablestake_queries 100.00% <ø> (ø)
perpetual_transactions 82.43% <ø> (ø)
perpetual_lifecycle 90.90% <ø> (ø)
perpetual_keeper 62.38% <ø> (ø)
perpetual_queries 61.32% <ø> (ø)
tier_transactions 25.00% <ø> (ø)
tier_lifecycle 100.00% <ø> (ø)
tier_keeper 90.90% <ø> (ø)
tier_queries 4.84% <ø> (ø)
tokenomics_transactions 71.87% <ø> (ø)
tokenomics_lifecycle ∅ <ø> (∅)
tokenomics_keeper 80.00% <ø> (ø)
tokenomics_queries 69.60% <ø> (ø)
transferhook_transactions ∅ <ø> (∅)
transferhook_lifecycle ∅ <ø> (∅)
transferhook_keeper 100.00% <ø> (ø)
transferhook_queries 11.11% <ø> (ø)
tradeshield_transactions 75.54% <ø> (ø)
tradeshield_lifecycle ∅ <ø> (∅)
tradeshield_keeper 90.90% <ø> (ø)
tradeshield_queries 21.55% <ø> (ø)

@cosmic-vagabond cosmic-vagabond merged commit 13c05fc into main Dec 6, 2024
70 of 74 checks passed
@cosmic-vagabond cosmic-vagabond deleted the fix/prevent-invalid-delegation-to-reward branch December 6, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants