-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chain ID references from 'elystestnet-1' to 'elysicstestnet-1'… #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across multiple files - Changed the chain ID in configuration files, scripts, and documentation to reflect the new test network name. - Removed the 'network.md' and 'troubleshooting.md' files as they are no longer needed. - Ensured consistency in CLI command examples by updating the chain ID in various scripts and usage documentation. This update improves clarity and aligns with the current network naming conventions.
cosmic-vagabond
temporarily deployed
to
coverage
December 9, 2024 02:12 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 45.89% 45.89%
=======================================
Files 939 939
Lines 35792 35792
=======================================
Hits 16425 16425
Misses 18079 18079
Partials 1288 1288 |
avkr003
requested changes
Dec 9, 2024
cosmic-vagabond
temporarily deployed
to
coverage
December 9, 2024 10:11 — with
GitHub Actions
Inactive
- Removed redundant `keyring-backend=test` from multiple CLI commands across various scripts to streamline usage. - Updated command examples in documentation and scripts to remove unnecessary parameters, enhancing readability and usability. - Adjusted references to the `elysicstestnet-1` chain ID in scripts and documentation to ensure uniformity. - Improved the clarity of the `README.md` and other documentation files by refining command examples and descriptions. - Deleted obsolete files such as `genesis.json`, `config.yml`, and `readme.md` from the `chain` directory to clean up the repository structure. These changes enhance the user experience by providing clearer instructions and reducing potential confusion in command usage.
cosmic-vagabond
temporarily deployed
to
coverage
December 9, 2024 16:49 — with
GitHub Actions
Inactive
- Deleted the `testnet.yml` configuration file, which contained account details, token definitions, and other network parameters. - This cleanup helps streamline the repository by removing obsolete configurations that are no longer needed.
cosmic-vagabond
temporarily deployed
to
coverage
December 9, 2024 16:51 — with
GitHub Actions
Inactive
cosmic-vagabond
temporarily deployed
to
coverage
December 9, 2024 16:52 — with
GitHub Actions
Inactive
avkr003
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… across multiple files
This update improves clarity and aligns with the current network naming conventions.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.