Feat/incenitve param #279
Feat/incenitve param #279
Conversation
|
|
||
| totalBlocksPerYear := sdk.NewInt(int64(inflation.EndBlockHeight - inflation.StartBlockHeight + 1)) | ||
| allocationEpochInblocks := totalBlocksPerYear.Quo(sdk.NewInt(ptypes.DaysPerYear)) | ||
| if len(params.LpIncentives) < 1 { |
There was a problem hiding this comment.
I think it would be good to update this to == 0 for clarity
| }) | ||
| } | ||
|
|
||
| if len(params.StakeIncentives) < 1 { |
There was a problem hiding this comment.
I think it would be good to update this to == 0 for clarity
| return fmt.Errorf("invalid parameter type: %T", i) | ||
| } | ||
|
|
||
| if v < 1 { |
There was a problem hiding this comment.
can you update this to v <= 0 to clearly express that it should be positive integer?
| return fmt.Errorf("invalid parameter type: %T", i) | ||
| } | ||
|
|
||
| if v < 1 { |
There was a problem hiding this comment.
can you update this to v <= 0 to clearly express that it should be positive integer?
| return false, types.IncentiveInfo{} | ||
| } | ||
| } | ||
|
|
||
| params.LpIncentives[0].CurrentEpochInBlocks = lpIncentive.CurrentEpochInBlocks |
There was a problem hiding this comment.
Is there any case LpIncentives[1] is used as well? It would be nice to add comments on what is LpIncentives[0] and what are the rest of [1:]
There was a problem hiding this comment.
LpIncentives[0] - this year
LpIncentives[1] - next year
| current_epoch_in_blocks: "0" | ||
| eden_boost_apr: "1" | ||
| lp_incentives: [] | ||
| stake_incentives: [] |
There was a problem hiding this comment.
@kenta-elys any reasons we are not getting rid of those params as you are using the ones from tokenomics now?
There was a problem hiding this comment.
@cosmic-vagabond I am still using the params in incentive module and filling in the value from tokenmocis module. Tokenmocis module params aren't enough to handle current incentive codebase. Let me think more if we can get rid of this.
|
Close this one as the next PR I made contains all the commits in this PR. |
Description
Closes:
What has Changed?
What specific problem were you aiming to address, and how did you successfully resolve it? If tests were not uploaded for this pull request or if coverage decreased, please provide an explanation for the change.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.