This repository has been archived by the owner on Dec 29, 2023. It is now read-only.
Feat/usdc price #16
Merged
Feat/usdc price #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kenta-elys
commented
Dec 8, 2023
•
kenta-elys
commented
- Add a special endpoint for querying usdc price on oracle.
politeWall
reviewed
Dec 8, 2023
src/msg/query_msg.rs
Outdated
| @@ -48,4 +50,6 @@ pub enum QueryMsg { | |||
| GetCommitments { delegator_addr: String }, | |||
| #[returns(QueryEarnPoolResponse)] | |||
| GetLiquidityPools { pool_ids: Option<Vec<u64>>, filter_type: FilterType, pagination: Option<PageRequest> }, | |||
| #[returns(Decimal)] | |||
There was a problem hiding this comment.
it would be better to return a Response msg
There was a problem hiding this comment.
you forgot to change it here
politeWall
reviewed
Dec 8, 2023
| let querier = ElysQuerier::new(&deps.querier); | ||
| let usdc_oracle_price = querier.get_oracle_price(ElysDenom::USDC.as_str().to_string(), "".to_string(), 0)?; | ||
| let usdc_usd_price = usdc_oracle_price.price.price.checked_div(Decimal::from_atomics(Uint128::new(1000000), 0).unwrap()).unwrap(); | ||
| Ok(usdc_usd_price) |
There was a problem hiding this comment.
it would be better to return a Response msg
politeWall
suggested changes
Dec 8, 2023
politeWall
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.