Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe only one subscription per Client is supported before, and only work for single client.
example:
client1 -> subscribe -> test {id: 1, method: "subscription",…}
client1 -> subscribe -> test2 {id: 2, method: "subscription",…}
client2 -> subscribe -> test {id: 1, method: "subscription",…}
client2 -> subscribe -> test {id: 2, method: "subscription",…}
Client2 will override Client1 Unsubscribable object.
observers { 1: Unsubscribable, 2: Unsubscribable }, Here may have memory leak and the observer still listener on event emitter.
proposed data structure :